test: add unit tests for IsPodReady, IsPodReadyConditionTrue and GetP…#7668
test: add unit tests for IsPodReady, IsPodReadyConditionTrue and GetP…#7668tushar-pandhare wants to merge 1 commit into
Conversation
…odReadyCondition Signed-off-by: Tushar Pandhare <tusharpandharetp@gmail.com>
karmada-bot
added
the
kind/cleanup
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the test coverage for core pod utility functions within the project. By introducing unit tests for status-related helper methods, it ensures that pod condition logic behaves as expected across different edge cases, contributing to better overall system reliability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
karmada-bot
added
the
size/L
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds unit tests for the IsPodReady, IsPodReadyConditionTrue, and GetPodReadyCondition helper functions in pkg/util/helper/pod_test.go. The review feedback highlights a potential panic in the IsPodReady helper function due to a missing nil check on the pod parameter, and suggests updating the helper function to handle nil safely and adding a corresponding test case.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| }) | ||
| } | ||
| } | ||
| func TestIsPodReady(t *testing.T) { |
There was a problem hiding this comment.
The helper function IsPodReady in pod.go does not perform a nil check on the pod parameter before accessing pod.Status. This can lead to a panic if a nil pod is passed. Please consider updating IsPodReady to handle nil safely (e.g., returning false), and then add a corresponding test case in TestIsPodReady to verify this behavior.
There was a problem hiding this comment.
Pull request overview
Adds missing unit test coverage for pod readiness helper functions in pkg/util/helper/pod.go, ensuring key readiness-condition branches are explicitly validated and reducing regression risk in readiness-related logic.
Changes:
- Add table-driven unit tests for
IsPodReadycovering no conditions, Ready=False, Ready=True. - Add table-driven unit tests for
IsPodReadyConditionTruecovering no conditions, Ready=False, Ready=Unknown, Ready=True. - Add table-driven unit tests for
GetPodReadyConditioncovering no conditions, Ready condition absent, Ready condition present.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7668 +/- ##
==========================================
- Coverage 42.15% 42.06% -0.10%
==========================================
Files 879 879
Lines 54669 54827 +158
==========================================
+ Hits 23047 23063 +16
- Misses 29875 30018 +143
+ Partials 1747 1746 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@RainbowMango @zhzhuang-zju PTAL, Thanks~ |
/kind cleanup
What this PR does / why we need it:
Add unit tests for three functions in
pkg/util/helper/pod.gothat lacked test coverage:IsPodReady— tests no conditions, Ready=False, Ready=TrueIsPodReadyConditionTrue— tests no conditions, Ready=False, Ready=Unknown, Ready=TrueGetPodReadyCondition— tests no conditions, Ready condition absent, Ready condition presentWhich issue(s) this PR fixes:
Fixes: #7667
Special notes for your reviewer:
All existing tests pass with the new additions:
ok github.com/karmada-io/karmada/pkg/util/helper
Does this PR introduce a user-facing change?:
NONE